provide permissions for 3-channel checks when called from deployment#64
Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If only the called
rust-stability.ymlworkflow needs these permissions, consider defining them in that reusable workflow underon.workflow_call.permissionsinstead of at the caller, so all callers share consistent permission requirements. - Double-check whether
issues: writeis strictly required for thequality-checkjob; if only read or no issues access is needed, reduce the permission scope accordingly to follow least-privilege principles.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If only the called `rust-stability.yml` workflow needs these permissions, consider defining them in that reusable workflow under `on.workflow_call.permissions` instead of at the caller, so all callers share consistent permission requirements.
- Double-check whether `issues: write` is strictly required for the `quality-check` job; if only read or no issues access is needed, reduce the permission scope accordingly to follow least-privilege principles.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.